[Bro-Dev] [JIRA] (BIT-1407) -f silently fails if base/frameworks/packet-filter isn't loaded

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20902#comment-20902 ] 

Robin Sommer commented on BIT-1407:
-----------------------------------





If we had that, the '-f' switch would probably be added by the packet
filter script, so it'd be available only when loaded.

I'd like to move argument processing into script-land as well.
Generally, however, I think it would still be good to avoid arguments
controlling script behaviour as much as possible. Main reason is
argument inflation: -f has been historically around but there are
plenty other scripts that in principle could take command-line
arguments as well, which would get messy. And we have the X=Y syntax
already to take care of that.



> -f silently fails if base/frameworks/packet-filter isn't loaded
> ---------------------------------------------------------------
>
>                 Key: BIT-1407
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1407
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>            Reporter: Vern Paxson
>         Attachments: signature.asc
>
>
> I know we've been through this before (though searching the tickets in Jira, I couldn't find the thread).  But to revisit: the "-f filter" option silently does nothing if base/frameworks/packet-filter isn't loaded (so the scenario here is using -b to suppress its automatic loading).  This can lead to seriously confusing behavior.  It would be preferable if there's either an error message indicating that the option won't be supported, or if it forced loading of packet-filter.



--
This message was sent by Atlassian JIRA
(v6.5-OD-05-041#65001)