[Bro-Dev] [JIRA] (BIT-874) Handling Modbus exception FC

[Jon Siwek (JIRA)]

     [ https://bro-tracker.atlassian.net/browse/BIT-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Siwek updated BIT-874:
--------------------------
    Fix Version/s:     (was: 2.4)
                   2.5

> Handling Modbus exception FC
> ----------------------------
>
>                 Key: BIT-874
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-874
>             Project: Bro Issue Tracker
>          Issue Type: Task
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: dina
>              Labels: ,, Modbus, analyser,, exception, fc
>             Fix For: 2.5
>
>
> event modbus_exception is a general exception and the 'fc' that is returned here is 'original_request_fc'+128. This means if I send a request with Fc=3 and something goes bad,I will get this exception with fc=131. I thought it would be useful to immediately subtract this value and show in the log exact Fc where the exception was triggered.  A small function for this I put before in modbus/utils.bro (on my branch), but its not in the topic/robin/modbus-merge branch. 
> I suggest to implement this functionality.



--
This message was sent by Atlassian JIRA
(v6.4-OD-15-055#64014)