[Bro-Dev] [JIRA] (BIT-683) Some BiFs should return a vector instead of a set/table

Jon Siwek (JIRA) jira at bro-tracker.atlassian.net
Tue Mar 17 08:53:01 PDT 2015

     [ https://bro-tracker.atlassian.net/browse/BIT-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Siwek updated BIT-683:
    Resolution: Fixed
        Status: Closed  (was: Open)

The "split" family of functions now return vectors based at index 0, see BIT-757.

Don't quite understand the comment about changing the "find_all" function, now that "split_string" returns a vector, "find_all" returning a set is serving a different use-case -- the one where you care about inspecting membership instead of ordering.  Open another ticket if there's still something left to do regarding "find_all".

> Some BiFs should return a vector instead of a set/table
> -------------------------------------------------------
>                 Key: BIT-683
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-683
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Matthias Vallentin
>              Labels: language
>             Fix For: 2.4
> The following functions should have a {{vector}} as yield value rather than a set/table:
> {noformat}
> split.*(...)
> find_all(...)
> {noformat}
> Moreover, {{split}} & friends have the yield value {{table[count] of string}} which starts at index 1. This is counterintuitive, as regular vectors start with a index at 0. I suggest replacing the yield value with {{vector of string}}.

This message was sent by Atlassian JIRA

More information about the bro-dev mailing list