[Bro-Dev] [JIRA] (BIT-342) Add payload to ICMP analyzer

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20025#comment-20025 ] 

Jon Siwek commented on BIT-342:
-------------------------------

topic/jsiwek/bit-342

> Add payload to ICMP analyzer
> ----------------------------
>
>                 Key: BIT-342
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-342
>             Project: Bro Issue Tracker
>          Issue Type: Patch
>          Components: Bro
>    Affects Versions: 1.5.2
>            Reporter: Seth Hall
>            Assignee: Jon Siwek
>             Fix For: 2.4
>
>         Attachments: ICMP-add-payload.diff
>
>
> This is a patch from Julien Sentier on the mailing list that makes ICMP payloads available at the scripting layer.  Is there a reason this isn't already available?  I would have committed it to fastpath except I don't know if it's not already doing this due to the potential overhead of creating a lot of strings in ICMP floods.  At the very least, I suppose it could be optional (which the patch doesn't currently do).



--
This message was sent by Atlassian JIRA
(v6.4-OD-15-055#64014)