[Bro-Dev] [JIRA] (BIT-1344) New SSH Analyzer

[Johanna Amann (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20108#comment-20108 ] 

Johanna Amann commented on BIT-1344:
------------------------------------

Hi,

just a few small questions I stumbled accross while merging this:
* is there a reason why you do not register the analyzer to port 22 by default? If I am not mistaken, the old one and basically all other protocol analyzers register to their well-known ports by default and just fail if they cannot parse the protocol.
* currently some of the texts in different files still state that login success/failure is determined by heuristics. Should we leave that text in or is it safe if I remove if while merging?

> New SSH Analyzer
> ----------------
>
>                 Key: BIT-1344
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1344
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: 2.4
>            Reporter: Vlad Grigorescu
>            Assignee: Johanna Amann
>
> The SSH analyzer was rewritten from scratch in topic/vladg/ssh.



--
This message was sent by Atlassian JIRA
(v6.4-OD-16-005#64014)