[Bro-Dev] [JIRA] (BIT-1343) Add Support for Including Common PAC Files

[Jon Siwek (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20202#comment-20202 ] 

Jon Siwek commented on BIT-1343:
--------------------------------

Just noting that I see ASN.1 parsing code has also been copied into the upcoming RDP analyzer.  (so remember to factor that out when addressing this ticket).

> Add Support for Including Common PAC Files
> ------------------------------------------
>
>                 Key: BIT-1343
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1343
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: BinPAC
>            Reporter: Vlad Grigorescu
>            Priority: Low
>
> With some new analyzers, we're duplicating code that we're shipping with Bro, due to a limitation in BinPAC - currently, BinPAC doesn't support %include-ing files from other directories. ASN.1 is a good example of this - SNMP and Kerberos both need a copy of the same ASN.1 parsing code. SMB also has some overlap with other analyzers.
> I tried the obvious fix of adding parsing support for {{%include ../snmp/asn1.pac}}, but the include paths get mixed up and compilation fails.
> I believe this should be a relatively simple fix.



--
This message was sent by Atlassian JIRA
(v6.4-OD-16-006#64014)