[Bro-Dev] [JIRA] (BIT-1501) smb_com_tree_connect_andx event not receiving correct parameters from analyzer

[Seth Hall (JIRA)]

     [ https://bro-tracker.atlassian.net/browse/BIT-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seth Hall updated BIT-1501:
---------------------------
    Resolution: Rejected
        Status: Closed  (was: Open)

Unfortunately that code you've patched is wildly out of date.  The SMB analyzer is not finished yet, but has been wildly rewritten and updated by Broala.  The current state can be found in topic/vladg/smb.

> smb_com_tree_connect_andx event not receiving correct parameters from analyzer
> ------------------------------------------------------------------------------
>
>                 Key: BIT-1501
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1501
>             Project: Bro Issue Tracker
>          Issue Type: Patch
>          Components: Bro
>    Affects Versions: 2.4
>            Reporter: David Smith
>            Priority: Low
>         Attachments: smb.patch
>
>
> smb_com_tree_connect_andx(c: connection, hdr: smb_hdr, path: string, service: string)
> in SMB.cc:   SMB_Session::ParseTreeConnectAndx
> the C++ function tries to pass a record as the third argument to the event and doesn't pass the fourth at all.  instead it should simply pass two strings for the third and fourth arguments.



--
This message was sent by Atlassian JIRA
(v7.0.0-OD-08-005#70107)