[Bro-Dev] [JIRA] (BIT-1263) Implementing three event handlers for supported data structure in Modbus Analyzer

[hui (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22637#comment-22637 ] 

hui commented on BIT-1263:
--------------------------

I don't think Robin would like to merge it without testcases. 

Too bad that I have not got any chance to collect some Modbus traces. But I do come across with a open source modbus library; I will try to see whether I can create some traces that can trigger these testcases by myself. Will let you guys know. 

> Implementing three event handlers for supported data structure in Modbus Analyzer
> ---------------------------------------------------------------------------------
>
>                 Key: BIT-1263
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1263
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>            Reporter: hui
>            Priority: Low
>              Labels: analyzer, modbus
>             Fix For: 2.5
>
>
> Three support data structures are defined in Modbus analyzer:
> FileRecordRequest,
> FileRecordResponse,
> ReferenceWithData
> Three event handlers are declared for them. 
> The changes are already made and pushed into the branch:
> topic/hui/modbus-events2



--
This message was sent by Atlassian JIRA
(v7.0.0-OD-08-002#70107)