[Bro-Dev] [JIRA] (BIT-1411) SQL_Injection_Victim is a misleading name

[Vern Paxson (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21969#comment-21969 ] 

Vern Paxson commented on BIT-1411:
----------------------------------

Boy I hope we're not past the where we can fix stuff like this.  There needs to be some model of deprecating/obsoleting deficient elements of the environment.  Ideally, we'd have mechanisms which can flag for users which parts of their setups have been deprecated and how to fix them.  But in any case, let's not be ossified!

> SQL_Injection_Victim is a misleading name
> -----------------------------------------
>
>                 Key: BIT-1411
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1411
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>            Reporter: Vern Paxson
>
> I suggest changing the name of this notice to {{SQL_Injection_Target}}.  Having "victim" in the name implies to me that the attack succeeded, which is not what the associated logic is about.
> Indeed, I even wonder if this notice is useful.  The information should be directly available from {{SQL_Injection_Attacker}} notices (though it doesn't appear to be currently set up to provide this - why not?).



--
This message was sent by Atlassian JIRA
(v7.0.0-OD-02-259#70102)