[Bro-Dev] [JIRA] (BIT-1479) seek functionality in RAW reader does not go to end of file

Lloyd Brown (JIRA) jira at bro-tracker.atlassian.net
Wed Sep 16 15:25:00 PDT 2015


    [ https://bro-tracker.atlassian.net/browse/BIT-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22103#comment-22103 ] 

Lloyd Brown edited comment on BIT-1479 at 9/16/15 5:24 PM:
-----------------------------------------------------------

Alternatively, you could simply choose between SEEK_SET and SEEK_END, before you optionally increment offset.

Edit: Never mind.  You were posting the fix about the same time as I was posting my comment.


was (Author: somewhere_or_other):
Alternatively, you could simply choose between SEEK_SET and SEEK_END, before you optionally increment offset.

> seek functionality in RAW reader does not go to end of file
> -----------------------------------------------------------
>
>                 Key: BIT-1479
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1479
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.4
>         Environment: running bin/bro version 2.4-87-debug on linux
>            Reporter: scampbell
>              Labels: input-framework
>
> When using the seek functionality for RAW input as described in 
> https://github.com/bro/bro/commit/cbba73ab12b3a9935162f008fe7d05ab61c5be6a
> The code on line 397-398 will push the suggested value of -1 to 0 which will disable the SEEK_END.  
> The fix would be to make the test if offset < -1, or to remove it in its entirety.
> many thanks!
> scott



--
This message was sent by Atlassian JIRA
(v7.0.0-OD-05-005#70102)


More information about the bro-dev mailing list