[Bro-Dev] [JIRA] (BIT-1481) some test canonifiers don't always read from stdin

Daniel Thayer (JIRA) jira at bro-tracker.atlassian.net
Sat Sep 19 22:48:00 PDT 2015

    [ https://bro-tracker.atlassian.net/browse/BIT-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22112#comment-22112 ] 

Daniel Thayer commented on BIT-1481:

In branch "topic/dnthayer/ticket1481" in the bro git repo, I've changed
a few canonifier scripts so that they no longer read their input
from a filename command-line argument.  I also removed two
canonifier scripts rather than convert them, because it appears
they are no longer being used.

In addition, I also fixed a few minor unrelated issues in a few canonifiers,
such as an off-by-one error in some "for" loops.

> some test canonifiers don't always read from stdin
> --------------------------------------------------
>                 Key: BIT-1481
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1481
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>            Reporter: Daniel Thayer
>            Assignee: Daniel Thayer
> Some of the test canonifier scripts being used in the Bro test suite
> cannot reliably be combined with other canonifiers in a pipeline.
> For example, this works:
> TEST_DIFF_CANONIFIER="diff-remove-x509-names | diff-remove-timestamps"
> but switching the order of these canonifiers does not work:
> TEST_DIFF_CANONIFIER="diff-remove-timestamps | diff-remove-x509-names"

This message was sent by Atlassian JIRA

More information about the bro-dev mailing list