[Bro-Dev] [JIRA] (BIT-1573) 3 useless EventHandlerPtr in the ARP Analyzer
jira at bro-tracker.atlassian.net
Wed Apr 27 02:04:02 PDT 2016
[ https://bro-tracker.atlassian.net/browse/BIT-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26000#comment-26000 ]
llh commented on BIT-1573:
I did make a successful test without the 3 lines. As I said in the description, the event handler pointers used and initialized are those declared in events.bif.h. Should you doubt about it, you can see that the event handler pointer ARP_Analyzer::arp_corrupted_packet is never referred to in the entire project, whereas the definitions of the functions of ARP_Analyzer refer to the global variables, including "bad_arp", which might be what the author wanted to name "arp_corrupted_packet".
Should I be wrong about removing those lines, it is still a bad idea to have class members with the same name as global variables (here "arp_request" and "arp_reply").
> 3 useless EventHandlerPtr in the ARP Analyzer
> Key: BIT-1573
> URL: https://bro-tracker.atlassian.net/browse/BIT-1573
> Project: Bro Issue Tracker
> Issue Type: Improvement
> Components: Bro
> Reporter: llh
> Priority: Trivial
> The class analyzer::arp::ARP_Analyzer declared in the file src/analyzer/protocol/arp/ARP.h declares 3 protected EventHandlerPtr that are never initialized and never used.
> What the corresponding source file refer to are the following global variables :
> * bad_arp
> * arp_request
> * arp_reply
> which are declared as "extern" in the file build/src/analyzer/protocol/arp/events.bif.h which is generated by bifcl from src/analyzer/protocol/arp/events.bif.
> Fixing this issue is trivial : deleting the 3 lines declaring the unused EventHandlerPtr.
> The expected improvement is saving 3 bytes of memory and mostly not messing with those who will try to understand the code of this analyzer in the future.
This message was sent by Atlassian JIRA
More information about the bro-dev