[Bro-Dev] Memory Leak in find_all()?
Dirk Leinenbach
dirk.leinenbach at consistec.de
Tue Feb 2 07:33:52 PST 2016
Hi,
I've just examined a memory leak in one of our installations and it
seems to be caused by find_all() from strings.bif in bro.
Running bro with perftools enabled (cf. [1]), I get leak reports, as
soon as my call to find_all() returns a non-empty list.
When changing find_all() in the following way (inspired by code in
IRC.cc), the leak is not reported anymore and my scripts still work as
expected:
old:
function find_all%(str: string, re: pattern%) : string_set
%{
TableVal* a = new TableVal(string_set);
const u_char* s = str->Bytes();
const u_char* e = s + str->Len();
for ( const u_char* t = s; t < e; ++t )
{
int n = re->MatchPrefix(t, e - t);
if ( n >= 0 )
{
a->Assign(new StringVal(n, (const char*) t), 0);
t += n - 1;
}
}
return a;
%}
new:
function find_all%(str: string, re: pattern%) : string_set
%{
TableVal* a = new TableVal(string_set);
const u_char* s = str->Bytes();
const u_char* e = s + str->Len();
for ( const u_char* t = s; t < e; ++t )
{
int n = re->MatchPrefix(t, e - t);
if ( n >= 0 )
{
Val* ma = new StringVal(n, (const char*) t);
a->Assign(ma, 0);
Unref(ma);
t += n - 1;
}
}
return a;
%}
Is my observation correct? If so, I could easily send a patch.
BTW: there seems to be another instance of the same problem in IRC.cc
Best regards,
Dirk
1) https://www.bro.org/development/howtos/leaks.html
--
Dr.-Ing. Dirk Leinenbach - Leitung Softwareentwicklung
consistec Engineering & Consulting GmbH
------------------------------------------------------------------
Europaallee 5 Fon: +49 (0)681 / 959044-0
D-66113 Saarbrücken Fax: +49 (0)681 / 959044-11
http://www.consistec.de e-mail: dirk.leinenbach at consistec.de
Registergericht: Amtsgericht Saarbrücken
Registerblatt: HRB12003
Geschäftsführer: Dr. Thomas Sinnwell, Volker Leiendecker, Stefan Sinnwell
More information about the bro-dev
mailing list