[Bro-Dev] [JIRA] (BIT-1521) known services should probably ignore gridftp-data

Seth Hall (JIRA) jira at bro-tracker.atlassian.net
Thu Jan 14 07:14:00 PST 2016

    [ https://bro-tracker.atlassian.net/browse/BIT-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23823#comment-23823 ] 

Seth Hall commented on BIT-1521:

Don’t put a set intersection function as a general utility function.  We probably shouldn’t be offering that generally right now since it should be added to the language in a way that performs better.  Since you’re only using it in a single location, just do a loop.

> known services should probably ignore gridftp-data
> --------------------------------------------------
>                 Key: BIT-1521
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1521
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: 2.4
>            Reporter: Justin Azoff
>            Assignee: Justin Azoff
>            Priority: Low
> known services script does
> {code}
>         if ( ! addr_matches_host(id$resp_h, service_tracking) ||
>              "ftp-data" in c$service || # don't include ftp data sessions
>              ("DNS" in c$service && c$resp$size == 0) ) # for dns, require that the server talks.
>                 return;
> {code}
> but should probably also ignore gridftp-data.  Probably a good idea to add a set of services that behave like ftp for it to check.

This message was sent by Atlassian JIRA

More information about the bro-dev mailing list