[Bro-Dev] [JIRA] (BIT-1498) add '-q' to ssh execution in ssh_runner.py

[Jon Schipp (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24806#comment-24806 ] 

Jon Schipp commented on BIT-1498:
---------------------------------

[~dnthayer] I pushed topic/jschipp/broctl-quiet-ssh-banner

> add '-q' to ssh execution in ssh_runner.py
> ------------------------------------------
>
>                 Key: BIT-1498
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1498
>             Project: Bro Issue Tracker
>          Issue Type: Patch
>          Components: BroControl
>    Affects Versions: 2.4
>            Reporter: scampbell
>            Assignee: Jon Schipp
>            Priority: Trivial
>              Labels: broctl
>             Fix For: 2.5
>
>
> When using broctl in an environment with login banners, they will be displayed in the broctl command.  In the event that they can not be configured away on the sshd end using '-q' avoids displaying the banner on the client side.
> The patch is trivial:
> --- a/BroControl/ssh_runner.py
> +++ b/BroControl/ssh_runner.py
> @@ -108,6 +108,7 @@ class SSHMaster:
>          self.base_cmd = [
>              "ssh",
>              "-o", "BatchMode=yes",
> +            "-q",
>              host,
>          ]
>          self.need_connect = True



--
This message was sent by Atlassian JIRA
(v7.2.0-OD-03-014#72000)