[Bro-Dev] [JIRA] (BIT-1550) Please merge topic/johanna/netcontrol

Jan Grashoefer (JIRA) jira at bro-tracker.atlassian.net
Sat Mar 12 14:23:00 PST 2016

    [ https://bro-tracker.atlassian.net/browse/BIT-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24809#comment-24809 ] 

Jan Grashoefer commented on BIT-1550:

That framework looks awesome! It's a pity, but last week I realized that the subnet-functionality would be nice to have to extend the intel-framework, so I did something similar to your changes in patricia tree and PrefixTable (see [https://github.com/J-Gras/bro/compare/master...J-Gras:topic/jgras/subnet]). My approach was different in the way that I did not return a list of subnets. I returned a table including only the subnets that contain the queried one, so you would not need to query each item again based on the list of matching subnets. Would you mind to have a look and tell me your opinion on this approach (excluding the function names... yours are much better :) )?

> Please merge topic/johanna/netcontrol
> -------------------------------------
>                 Key: BIT-1550
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1550
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Johanna Amann
>            Assignee: Robin Sommer
>             Fix For: 2.5
> Please merge topic/johanna/netcontrol, which contains the NetControl framework and some small core changes necessary for it.
> The core changes are:
>  - add support for the PrefixTable and patricia tree to dump lists of covered IP addresses
>  - add a number of bifs
>  - add tracking of recursive types to prevent crash when a function contains a record as an argument in which the function is a member of
> The framework will get a few small updates in the future. However, these mostly should be small missing features and either not affect the API at all, or only contain minor changes.

This message was sent by Atlassian JIRA

More information about the bro-dev mailing list