[Bro-Dev] [JIRA] (BIT-1550) Please merge topic/johanna/netcontrol

Johanna Amann (JIRA) jira at bro-tracker.atlassian.net
Sat Mar 12 20:48:00 PST 2016


    [ https://bro-tracker.atlassian.net/browse/BIT-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24810#comment-24810 ] 

Johanna Amann commented on BIT-1550:
------------------------------------

I think both approaches are valid - it just depends on your use-case which is more appropriate. For what I am using them for, I really only needed the list of subnets (and not constructing the whole table has a lower overhead).

I will try to just fold that into my current patch sometime end-of-next-week-ish. I will probably do it a bit different, but that mostly is a style thing (and on a first glance, your code has a few gotchas - I think constructing the table as having the type table[subnet] of any can lead to a few interesting issues, e.g.).

> Please merge topic/johanna/netcontrol
> -------------------------------------
>
>                 Key: BIT-1550
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1550
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>    Affects Versions: git/master
>            Reporter: Johanna Amann
>            Assignee: Robin Sommer
>             Fix For: 2.5
>
>
> Please merge topic/johanna/netcontrol, which contains the NetControl framework and some small core changes necessary for it.
> The core changes are:
>  - add support for the PrefixTable and patricia tree to dump lists of covered IP addresses
>  - add a number of bifs
>  - add tracking of recursive types to prevent crash when a function contains a record as an argument in which the function is a member of
> The framework will get a few small updates in the future. However, these mostly should be small missing features and either not affect the API at all, or only contain minor changes.



--
This message was sent by Atlassian JIRA
(v7.2.0-OD-03-014#72000)


More information about the bro-dev mailing list