[Bro-Dev] [JIRA] (BIT-1561) Pull Request to fix resource leaking in BroControl Python API

[Daniel Thayer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25307#comment-25307 ] 

Daniel Thayer commented on BIT-1561:
------------------------------------

Each time a broctl command is run that uses broccoli, a new TCP connection
is established.  The connection is not closed until one either exits from broctl,
or stops the Bro nodes.

Ideally, it would reuse the TCP connection, but at least your fix is better than the current
situation.


> Pull Request to fix resource leaking in BroControl Python API
> -------------------------------------------------------------
>
>                 Key: BIT-1561
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1561
>             Project: Bro Issue Tracker
>          Issue Type: Patch
>          Components: BroControl
>            Reporter: Aaron Eppert
>              Labels: broctl
>
> connDelete() is never called in broctl, which is generally not an issue if it is being used via the command line. However, given the Python interface for calling into broctl, if a service is written around broctl and any parallel events are sent (peerstatus, netstats, etc.) then a TCP connection will be maintained given a connDelete() is not called. After a fairly certain interval, resources become an issue and things fail.
> https://github.com/bro/broctl/pull/4



--
This message was sent by Atlassian JIRA
(v7.2.0-OD-05-022#72002)