[Bro-Dev] Final Broker branch testing

[Daniel Thayer]

I noticed that Bro no longer builds on any version of RHEL/CentOS:

CMake Error at aux/broker/CMakeLists.txt:4 (cmake_minimum_required):
   CMake 3.0.2 or higher is required.  You are running version 2.8.12.2

--------------------------------------------------------------------
Also, I observed the following test failures on debian 9 (there
were a few other failures, but they went away after running
"btest -r" once):

$ cat diag.log
scripts.base.frameworks.control.id_value ... failed
   % 'btest-diff controller/.stdout' failed unexpectedly (exit code 1)
   % cat .diag
   == File ===============================
   == Diff ===============================
   --- /tmp/test-diff.13239.controller..stdout.baseline.tmp	2018-04-26 
19:16:51.327612039 +0000
   +++ /tmp/test-diff.13239.controller..stdout.tmp	2018-04-26 
19:16:51.327612039 +0000
   @@ -1 +0,0 @@
   -Got an id_value_response(test_var, This is the value from the 
controllee) event
   =======================================

   % cat .stderr
   <<< [13137] 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.id_value/id_value.bro 
only-for-controllee frameworks/control/controllee 
Broker::default_port=65532/tcp
   <params>, line 1: received termination signal
   >>>
   <<< [13165] 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.id_value/id_value.bro 
frameworks/control/controller Control::host=127.0.0.1 
Control::host_port=65532/tcp Control::cmd=id_value Control::arg=test_var
   <params>, line 1: received termination signal
   >>>

scripts.base.frameworks.control.shutdown ... failed
   % 'btest-bg-wait 10' failed unexpectedly (exit code 1)
   % cat .stderr
   The following processes did not terminate:

 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.shutdown/shutdown.bro 
frameworks/control/controller Control::host=127.0.0.1 
Control::host_port=65530/tcp Control::cmd=shutdown

   -----------
   <<< [13281] 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.shutdown/shutdown.bro 
frameworks/control/controllee Broker::default_port=65530/tcp
   <params>, line 1: received termination signal
   >>>
   <<< [13309] 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.shutdown/shutdown.bro 
frameworks/control/controller Control::host=127.0.0.1 
Control::host_port=65530/tcp Control::cmd=shutdown
   <params>, line 1: received termination signal
   >>>

-----------------------------------------------------------------------
I also observed the following test failures on ubuntu 16.04LTS (there
were a few other test failures, but they went away after running
"btest -r" once):

$ cat diag.log
scripts.base.frameworks.control.id_value ... failed
   % 'btest-diff controller/.stdout' failed unexpectedly (exit code 1)
   % cat .diag
   == File ===============================
   == Diff ===============================
   --- /tmp/test-diff.14643.controller..stdout.baseline.tmp	2018-04-26 
19:18:05.246312235 +0000
   +++ /tmp/test-diff.14643.controller..stdout.tmp	2018-04-26 
19:18:05.246312235 +0000
   @@ -1 +0,0 @@
   -Got an id_value_response(test_var, This is the value from the 
controllee) event
   =======================================

   % cat .stderr
   <<< [14541] 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.id_value/id_value.bro 
only-for-controllee frameworks/control/controllee 
Broker::default_port=65532/tcp
   <params>, line 1: received termination signal
   >>>
   <<< [14569] 
BROPATH=.:/home/repo/bro/scripts:/home/repo/bro/scripts/policy:/home/repo/bro/scripts/site:/home/repo/bro/build/scripts:.. 
bro 
/home/repo/bro/testing/btest/.tmp/scripts.base.frameworks.control.id_value/id_value.bro 
frameworks/control/controller Control::host=127.0.0.1 
Control::host_port=65532/tcp Control::cmd=id_value Control::arg=test_var
   <params>, line 1: received termination signal
   >>>
-----------------------------------------------------------------------