[Bro-Dev] DHCP event removal

Michał Purzyński michalpurzynski1 at gmail.com
Sun Jun 17 12:48:46 PDT 2018


No idea what’s in master. It should be trivial if you don’t remove the dhcp analyzer completely.

> On Jun 16, 2018, at 6:07 AM, Vlad Grigorescu <vlad at es.net> wrote:
> 
> Yep, already working on it. :-)
> 
>> On Sat, Jun 16, 2018 at 6:26 AM, Seth Hall <seth at corelight.com> wrote:
>> 
>> On 15 Jun 2018, at 17:22, Azoff, Justin S wrote:
>> 
>> > The fix is a little trickier, you can't handle both events because the 
>> > DHCP::Msg type no longer exists and you need to wrap the old event 
>> > with
>> >
>> > @ifdef (DHCP::Msg)
>> > @endif
>> 
>> Ugh, I didn't consider that.  Bro has re-reached the point where 
>> touching any number of things can set off an avalanche of problems like 
>> this.
>> 
>> Anyone on this thread up for submitting a patch which makes Bro cope 
>> with the changes automatically?  You can then even mark the old events 
>> as deprecated. :)
>> 
>>   .Seth
>> 
>> --
>> Seth Hall * Corelight, Inc * www.corelight.com
>> _______________________________________________
>> bro-dev mailing list
>> bro-dev at bro.org
>> http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
> 
> _______________________________________________
> bro-dev mailing list
> bro-dev at bro.org
> http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.icsi.berkeley.edu/pipermail/bro-dev/attachments/20180617/ee88e7e1/attachment.html 


More information about the bro-dev mailing list