[Bro-Dev] SSH Capabilities Bug: Fix for 2.6?

Jon Siwek jsiwek at corelight.com
Mon Oct 15 14:19:23 PDT 2018


On Mon, Oct 15, 2018 at 3:33 PM Vlad Grigorescu <vlad at es.net> wrote:

> The SSH Capabilities record has the following field, which is being set incorrectly:
>
>>         ## Are these the capabilities of the server?
>>         is_server:                  bool;
>
>> result->Assign(6, new Val(${msg.is_orig}, TYPE_BOOL));
>
> Obviously, I'd like to fix this. I'm curious to hear thoughts about getting this into 2.6.

Yes, that seems like a bug fix that can be included in 2.6.  Do you
want to make a PR for that and verify/update any unit test baselines
that change?

- Jon


More information about the bro-dev mailing list