[Zeek-Dev] PR coordination with external testing suite
Jeff Barber
jsbarber60 at gmail.com
Mon Jul 29 09:12:47 PDT 2019
Hi Zeek devs,
I found an issue with duplicate packets not getting properly marked as TCP
retransmissions. I generated a PR for it on Friday (
https://github.com/zeek/zeek/pull/494), including the necessary changes to
make the built-in test suite pass.
However, the automatic Travis CI process that gets executed for a PR is
also downloading tests from an external repo:
https://github.com/zeek/zeek-testing and those tests are failing -- because
the fix changes the connection history values in all the connections (many
traces actually have duplicate packets in them that were previously not
noted in the history string).
The real question here is:
I don't mind updating the zeek-testing repo for the necessary changes, but
how would I coordinate that change? "this zeek PR needs to go with that
zeek-testing PR"
Jeff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.icsi.berkeley.edu/pipermail/zeek-dev/attachments/20190729/2f3e8db4/attachment.html
More information about the zeek-dev
mailing list