bro dies (every day)

[Robin Sommer]

On Fri, Aug 22, 2003 at 08:05 -0700, Scott Campbell wrote:

> 1060118249.065749 <no location> (128.3.11.35): bad tag in Val::CONVERTER

Could you try the attached patch and see if it helps?

Robin

-- 
Robin Sommer * Room        01.08.055 * www.net.in.tum.de
TU Munich    * Phone (089) 289-18006 *  sommer at in.tum.de 
-------------- next part --------------
diff -uNrbB bro-pub-0.8a34/ICMP.cc bro-patched/ICMP.cc
--- bro-pub-0.8a34/ICMP.cc	Sun Jul 13 21:23:45 2003
+++ bro-patched/ICMP.cc	Mon Aug 18 13:02:53 2003
@@ -30,6 +30,7 @@
 		const ConnID* id, const struct icmp* /* icmpp */)
 : Connection(s, k, t, id)
 	{
+	icmp_conn_val = 0;
 	}
 
 void ICMP_Connection::Done()
@@ -98,19 +99,19 @@
 
 RecordVal* ICMP_Connection::BuildICMPVal()
 	{
-	if ( ! conn_val )
+	if ( ! icmp_conn_val )
 		{
-		conn_val = new RecordVal(icmp_conn);
+		icmp_conn_val = new RecordVal(icmp_conn);
 
-		conn_val->Assign(0, new AddrVal(orig_addr));
-		conn_val->Assign(1, new AddrVal(resp_addr));
-		conn_val->Assign(2, new Val(type, TYPE_COUNT));
-		conn_val->Assign(3, new Val(code, TYPE_COUNT));
+		icmp_conn_val->Assign(0, new AddrVal(orig_addr));
+		icmp_conn_val->Assign(1, new AddrVal(resp_addr));
+		icmp_conn_val->Assign(2, new Val(type, TYPE_COUNT));
+		icmp_conn_val->Assign(3, new Val(code, TYPE_COUNT));
 		}
 
-	Ref(conn_val);
+	Ref(icmp_conn_val);
 
-	return conn_val;
+	return icmp_conn_val;
 	}
 
 int ICMP_Connection::IsReuse(double /* t */, const u_char* /* pkt */)
diff -uNrbB bro-pub-0.8a34/ICMP.h bro-patched/ICMP.h
--- bro-pub-0.8a34/ICMP.h	Sat Oct 26 19:03:53 2002
+++ bro-patched/ICMP.h	Mon Aug 18 13:02:53 2003
@@ -54,6 +54,7 @@
 	virtual void NextICMP(double t, const struct icmp* icmpp,
 				int len, int caplen, const u_char*& data);
 
+	RecordVal *icmp_conn_val;
 	int type;
 	int code;
 };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mailman.ICSI.Berkeley.EDU/pipermail/bro/attachments/20030822/71cb2912/attachment.bin