Segmentation fault with RuleMatcher

[Yohann Thomas]

Arghhhh...It still doesn't work...(Seg Fault)

But I noticed in the patch the following lines :

if ( resp_match_state )

	rule_matcher->FinishEndpoint(orig_match_state);


I'm sorry if I'm wrong, but, just looking at the structure of the code, 
I thought it could be "resp_match_state" instead of "orig_match_state".
In fact, I tried this and it seems to work now. :-)

How do you feel about that ???

Yohann.




Robin Sommer wrote:

>
> On Tue, May 04, 2004 at 11:24 +0200, Yohann Thomas wrote:
>
> > I dumped a core, to locate the problem, and it seems to crash in
> > RuleMatcher::ExecRule.
>
> Sorry, it took me while to get back to this. Could you try the
> attached patch and see if it helps?
>
> Robin
>
> -- 
> Robin Sommer * Room        01.08.055 * www.net.in.tum.de
> TU Muenchen  * Phone (089) 289-18006 *  sommer at in.tum.de
>
>------------------------------------------------------------------------
>
>Common subdirectories: bro-pub-0.8a82/aux and bro-pub-0.8a82-patched/aux
>diff -u bro-pub-0.8a82/Conn.cc bro-pub-0.8a82-patched/Conn.cc
>--- bro-pub-0.8a82/Conn.cc	2004-04-27 21:00:13.000000000 +0200
>+++ bro-pub-0.8a82-patched/Conn.cc	2004-05-18 13:46:38.000000000 +0200
>@@ -724,16 +724,13 @@
> 		return;
> 
> 	if ( orig_match_state )
>-		{
> 		rule_matcher->FinishEndpoint(orig_match_state);
>-		delete orig_match_state;
>-		}
> 
> 	if ( resp_match_state )
>-		{
>-		rule_matcher->FinishEndpoint(resp_match_state);
>-		delete resp_match_state;
>-		}
>+		rule_matcher->FinishEndpoint(orig_match_state);
>+
>+	delete orig_match_state;
>+	delete resp_match_state;
> 
> 	orig_match_state = resp_match_state = 0;
> 	}
>Common subdirectories: bro-pub-0.8a82/doc and bro-pub-0.8a82-patched/doc
>Common subdirectories: bro-pub-0.8a82/example-attacks and bro-pub-0.8a82-patched/example-attacks
>Common subdirectories: bro-pub-0.8a82/linux-include and bro-pub-0.8a82-patched/linux-include
>Common subdirectories: bro-pub-0.8a82/policy and bro-pub-0.8a82-patched/policy
>Only in bro-pub-0.8a82-patched/: tmp
>  
>