[Bro] Small bug in TCP_Rewriter

Fri Jul 15 14:36:53 PDT 2005

Hey Martin :)

On Fri, 2005-07-15 at 14:01 -0700, Martin Casado wrote:
>  Hi,
> 
>  This may already be fixed but I believe there is a bug in the TCP 
> rewriter.  I'm using
> bro 0.9a10.5.
> 
>  File TCP_Rewriter.cc, Line 710:
> 
>        ASSERT(next_packet->AppendData(data, left));
>  
> If the ASSERT preprocessor conditional isn't enabled, the statement 
> isn't included in the
> translation unit  and using -A for re-writing doesn't include any 
> payload (only headers) :(

Uh-oh. Smells rotten to me!

> Plz. let me know if this isn't the appropriate forum for submitting bugs.

Oh definitely. Keep 'em coming...

Cheers,
Christian.
-- 
________________________________________________________________________
                                          http://www.cl.cam.ac.uk/~cpk25
                                                    http://www.whoop.org