[Bro] RemoteSerializer.cc

[Christian Kreibich]

Hi,

afaik this is just a band aid until we've implemented an app-layer flow
control scheme -- killing a connection is suboptimal in any case. Is the
issue you're describing a problem you're seeing in practice?

On Sun, 2006-10-15 at 19:53 +0200, Sandro Reichert wrote:
> SocketComm::Run (): lines 2333 to 2361
> [1] if ( io->IsFillingUp() && ! shutting_conns_down ) {}
> and [2] if ( ! io->IsFillingUp() && shutting_conns_down ) {}
> 
> example:
> - bro node A is connected to nodes B and C.
> - B sent 4GB, C only 20MB
> - now C generates much traffic and A's queue to parent is filling up
>    -> [1] becomes true, but instead of C, B is detected as the 
> connection with the heaviest traffic and therefor disconnected;
> shutting_conns_down = true.
> - C still floods A, [1] and [2] are false and C can't be stopped. (?)
[...]

Cheers,
Christian.
-- 
________________________________________________________________________
                                          http://www.cl.cam.ac.uk/~cpk25
                                                    http://www.whoop.org