[Bro] Segmentation fault when installing a rotate timer in BroFile

[Po-Ching Lin]

Thanks, Vern.

The segmentation fault disappears after the patch is applied.

Po-Ching

On Mon, 05 Nov 2007 22:38:06 -0800
Vern Paxson <vern at icir.org> wrote:

> > Program received signal SIGSEGV, Segmentation fault.
> > 0x080eed0d in BroFile::InstallRotateTimer (this=0x90b4030) at File.cc:562
> > 562             timer_mgr->Add(rotate_timer);
> 
> This came up a little while ago on the mailing list.  See if the following
> does the trick.
> 
> 		Vern
> 
> 
> Date:  Wed, 19 Sep 2007 12:50:23 +0800
> From:  "CS Lee" <geek00l at gmail.com>
> Subject:  Re: [Bro] Rotate log time issue - bro seg fault
> To:  "Vern Paxson" <vern at icir.org>
> Cc:  bro at icsi.berkeley.edu
> 
> ------=_Part_17020_2333909.1190177423900
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
> 
> Hi Vern,
> 
> The patch works! There's no more segfault after the patch is applied.
> 
> Thanks.
> 
> On 9/19/07, Vern Paxson <vern at icir.org> wrote:
> >
> > > The bro-1.3.2. that we installed having the same revision which is 4657
> > -
> >
> > Ah.  Then please try this one.
> >
> >                 Vern
> >
> >
> > Index: File.cc
> > ===================================================================
> > --- File.cc     (revision 4763)
> > +++ File.cc     (revision 4773)
> > @@ -539,6 +539,9 @@
> >
> > void BroFile::InstallRotateTimer()
> >         {
> > +       if ( terminating )
> > +               return;
> > +
> >         if ( rotate_timer )
> >                 {
> >                 timer_mgr->Cancel(rotate_timer);

-- 
Po-Ching Lin <pclin at cis.nctu.edu.tw>