[Bro] [PATCH] Fix signedness issue in src/nb_dns.c

Kevin Lo kevlo at kevlo.org
Wed Apr 23 18:34:55 PDT 2008


Robin Sommer wrote:
> Thanks for the patch!
> 
> On Wed, Apr 23, 2008 at 15:32 +0800, you wrote:
> 
> > -	hp = (HEADER *)msg;
> > +	hp = (HEADER *)(u_char *)msg;
> 
> I'm not sure I understand this change? Isn't the second cast
> neutralized by the first?

Oops, I sent the wrong diff :-( 
Here's the correct patch. Sorry for the confusion!

> Robin

	Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-src-nb_dns.c
Type: text/x-patch
Size: 765 bytes
Desc: not available
Url : http://mailman.ICSI.Berkeley.EDU/pipermail/bro/attachments/20080424/27287a78/attachment.bin 


More information about the Bro mailing list