[Bro] Issues with DESTDIR support

[Hank Leininger]

On Thu, Mar 08, 2012 at 04:17:37PM +0000, Siwek, Jonathan Luke wrote:
> 
> Seems in that change I did yesterday I was mistakenly replacing the
> install prefix with DESTDIR instead of just prepending to it.  I fixed
> that in the same branch which you can try out by doing this command in
> your bro repository (assuming it's the same one from yesterday with
> the branch already checked out):

I think this is getting closer.  But it throws an error at:

  [snip]
  -- Installing: /var/tmp/portage/net-analyzer/bro-2.0.20120309/image/var/opt/bro/spool/scripts
  -- Installing: /var/tmp/portage/net-analyzer/bro-2.0.20120309/image/var/opt/bro/logs
  ACCESS DENIED  symlink: /opt/bro/share/broctl/scripts/broctl-config.sh
  -- Installing: /var/tmp/portage/net-analyzer/bro-2.0.20120309/image///opt/bro/etc/broctl.cfg
  -- Installing: /var/tmp/portage/net-analyzer/bro-2.0.20120309/image///opt/bro/etc/networks.cfg
  [snip]

It looks like the command that's failing is:

  /usr/bin/cmake -E create_symlink /var/opt/bro/spool/broctl-config.sh /opt/bro/share/broctl/scripts/broctl-config.sh

That's in ./build/aux/broctl/cmake_install.cmake.  When I manually add
$ENV{DESTDIR} as a prefix for the destination and re-merge, it works
cleanly, and I end up with a sane-looking install--except that
/var/opt/bro/spool/broctl-config.sh does not exist, so the symlink at
/opt/bro/share/broctl/scripts/broctl-config.sh is dangling (could be a
side effect of my manual hack?)

Thanks,

Hank
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 447 bytes
Desc: Digital signature
Url : http://mailman.ICSI.Berkeley.EDU/pipermail/bro/attachments/20120309/575ccf8a/attachment.bin