[Bro] broctly deploy hangs on checking scripts

[Azoff, Justin S]

Yeah, that would do it.. but it would break like that 100% of the time, not only when bro was running.

Daniel, do you remember why we use terminate_communication() instead of exit_only_after_terminate + terminate() ?

I vaguely remember something about terminate_communication being misused somewhere else that had issues with the switch to broker.

-- 
- Justin Azoff

> On Dec 2, 2016, at 10:10 AM, Mike Dopheide <dopheide at gmail.com> wrote:
> 
> If you have exit_only_after_terminate set, usually for debugging, we've had that hang the 'bro check'.
> 
> -Dop
> 
> On Fri, Dec 2, 2016 at 9:11 AM, erik clark <philosnef at gmail.com> wrote:
> Yes, seeing this in 2.5. 
> 
> On Fri, Dec 2, 2016 at 9:22 AM, Azoff, Justin S <jazoff at illinois.edu> wrote:
> > On Dec 2, 2016, at 7:42 AM, erik clark <philosnef at gmail.com> wrote:
> >
> > If I have bro running and try a broctl deploy, it hangs on checking scripts. I have confirmed there are no files owned by a user other than the one running bro. If I stop bro first, do an install, then do a check, it does it very fast and cleanly.
> 
> I used to see that occasionally when the manager was extremely heavily loaded... but it's been a while (I thought Daniel fixed it?).  It was some sort of race condition in the command/script that check runs that causes it to not exit.
> 
> all the check script itself does is start bro with
> 
> event bro_init() &priority=-10
>         {
>         terminate_communication();
>         }
> 
> Are you still seeing this on 2.5?
> 
> --
> - Justin Azoff
> 
> 
> 
> 
> 
> _______________________________________________
> Bro mailing list
> bro at bro-ids.org
> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/bro
>