[Bro] broctly deploy hangs on checking scripts

Daniel Thayer dnthayer at illinois.edu
Sat Dec 3 21:58:25 PST 2016


OK, would you be willing to try the attached patch?
I'd like to know if it prevents "broctl deploy" (or "broctl check")
from hanging.

To apply the patch, you don't need to re-install Bro,
you can just patch the installed copy (replace $PREFIX
with your Bro install prefix directory, such as /usr/local/bro):
cd $PREFIX
patch -p0 -b < check.patch
-------------- next part --------------
--- lib/broctl/BroControl/control.py.orig	2016-12-03 23:36:57.000000000 -0600
+++ lib/broctl/BroControl/control.py	2016-12-03 23:34:34.000000000 -0600
@@ -694,6 +694,8 @@
 
             cmd = os.path.join(self.config.scriptsdir, "check-config") + " %s %s %s %s" % (installed_policies, print_scripts, cwd, " ".join(_make_bro_params(node, False)))
             cmd += " broctl/check"
+            if not list_scripts:
+                cmd += " -a"
 
             cmds += [((node, cwd), cmd, env, None)]
 


More information about the Bro mailing list