No subject

Fri Jan 28 12:54:58 2005
Return-Path: xorp-cvs-admin@icir.org
Delivery-Date: Fri, 28 Jan 2005 12:55:02 -0800
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by tigger.icir.org (8.12.11/8.12.8) with ESMTP id j0SKt2nY009181
	for <atanu@tigger.icir.org>; Fri, 28 Jan 2005 12:55:02 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU [192.150.186.11])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0SKt21x014733
	for <atanu@icir.org>; Fri, 28 Jan 2005 12:55:02 -0800 (PST)
	(envelope-from xorp-cvs-admin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (localhost [127.0.0.1])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0SKt2Ip019180;
	Fri, 28 Jan 2005 12:55:02 -0800 (PST)
Received: from wyvern.icir.org (wyvern.icir.org [192.150.187.14])
	by fruitcake.ICSI.Berkeley.EDU (8.12.10/8.12.9) with ESMTP id j0SKswIp019172
	for <xorp-cvs@icsi.berkeley.edu>; Fri, 28 Jan 2005 12:54:58 -0800 (PST)
Received: from possum.icir.org (possum.icir.org [192.150.187.67])
	by wyvern.icir.org (8.12.9p1/8.12.8) with ESMTP id j0SKsw1x014727;
	Fri, 28 Jan 2005 12:54:58 -0800 (PST)
	(envelope-from pavlin@icir.org)
Received: from possum.icir.org (localhost [127.0.0.1])
	by possum.icir.org (8.12.11/8.12.8) with ESMTP id j0SKswet069756;
	Fri, 28 Jan 2005 12:54:58 -0800 (PST)
	(envelope-from pavlin@possum.icir.org)
Message-Id: <200501282054.j0SKswet069756@possum.icir.org>
To: Bruce M Simpson <bms@spc.org>
cc: Pavlin Radoslavov <pavlin@icir.org>, xorp-cvs@icir.org
Subject: Re: [Xorp-cvs] XORP cvs commit: xorp/libxorp 
In-Reply-To: Message from Bruce M Simpson <bms@spc.org> 
   of "Fri, 28 Jan 2005 20:44:37 GMT." <20050128204437.GL24432@dhcp120.icir.org> 
Date: Fri, 28 Jan 2005 12:54:58 -0800
From: Pavlin Radoslavov <pavlin@icir.org>
Sender: xorp-cvs-admin@icir.org
Errors-To: xorp-cvs-admin@icir.org
X-BeenThere: xorp-cvs@icir.org
X-Mailman-Version: 2.0
Precedence: bulk
List-Help: <mailto:xorp-cvs-request@icir.org?subject=help>
List-Post: <mailto:xorp-cvs@icir.org>
List-Subscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=subscribe>
List-Id: Mailing list for XORP CVS commit messages <xorp-cvs.icir.org>
List-Unsubscribe: <http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs>,
	<mailto:xorp-cvs-request@icir.org?subject=unsubscribe>

> On Fri, Jan 28, 2005 at 03:30:15AM +0000, Pavlin Radoslavov wrote:
> > Log message:
> > 	Remove <net/route.h> and <arpa/inet.h> from the list of included
> > 	files, because they shouldn't be here.
> 
> This change breaks my uncommitted fix for bug# 110, which needs <arpa/inet.h>
> to print a meaningful error message when bind() fails.
> 
> I've reintroduced the required includes to socket.cc itself on my
> private branch, do you have suggestions as to how/where we should
> detect that inet_ntop() is defined?

In general, if the above two files are needed somewhere, then I'd
say to include them as needed. So far they are needed in very
few places.

> Or would it be better to cast the sockaddrs to XORP IPvX library types?

You could use this solution if you like, up to you.
Though, as you know in the future the goal is that the TCP
connections should go via the FEA hence the above code will
eventually be removed.

About the inet_ntop detection, lets discuss it out-of-band.

Regards,
Pavlin
_______________________________________________
Xorp-cvs mailing list
Xorp-cvs@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-cvs