[Xorp-hackers] Patches not commited!?

[Kristian Larsson]

On Tue, Oct 11, 2005 at 09:47:59AM -0700, Pavlin Radoslavov wrote:
> > I understand you have quite a lot to do ;)
> > It seems that not many of the developers listed on
> > the xorp webpage are actually active. Perhaps
> > another person with CVS access could help out. And
> > with that person having bugs/BugZilla as main
> > focus all these small bugs could be resolved very
> > quickly.
> > 
> > Anyway here is a (partial?) list.
> > 53
> > 54
> > 64
> > 161
> > 199
> > 212
> > 217
> 
> Thanks for the list. Accidentally, last night I found by accident
> and already fixed the problem described in Bugzilla entry #212, so I
> just marked that FIXED.
> 
> Atanu is the one to take care of #217, but recently he is overloaded
> with the OSPF implementation so probably after that he will take
> care of it.
> 
> Note that in general even if there is a patch for a problem it is
> not just a question of applying that patch. We need to verify it and
> modify it if necessary (e.g., to match the XORP codingguidelines,
> etc). Occasionally, we need to think about the high-level impact of
> a solution. A not so good example could be whether we want to have a
> special template that defines the header of the XORP configuration
> files or whether the format of that header would be hardcoded inside
> the *.cc files.
> 
> Anyway, I created a note for myself with the above bugzilla entries
> so I will try to address them sooner than later (though note that
> some of them may have to be postponed until after the release
> because of the significant impact they have on the system).
> 
> Unfortunately, it is quite hard to have a person that addresses all
> the bugzilla entries, because typically fixing a bug requires deep
> understanding of how the particular module works. E.g., I deal with
> multicast bugs, Atanu deals with BGP bugs, etc.

Valid point ;)
I was thinking of all the small trivial fixes.
Somehow I feel they should be given some form of
priority. If someone sends a patch to BZ I think
it's important that the patch is at least looked
over.

Perhaps an addition to BugZilla which makes it
possible to search for bugs with patches. This way
you could search for patched bugs ones a week,
verify and commit :)


   Kristian.