[Bro-Dev] [JIRA] (BIT-1091) Broctl config.py handling of [manager] header is brittle
jira at bro-tracker.atlassian.net
Thu Oct 17 14:45:51 PDT 2013
Bob created BIT-1091:
Summary: Broctl config.py handling of [manager] header is brittle
Project: Bro Issue Tracker
Issue Type: Problem
Affects Versions: 2.2
$prefix/lib/broctl/BroControl/config.py (line 159, in nodes()) special cases the manager node of the etc/node.cfg config and checks it by the attribute n.name, as opposed to all of the other types that are handled earlier in the function, which get checked by the attribute n.type. This means that anyone who might try to set a more descriptive manager name, like [broproductionmanager] or [brotestmanager], will break broctl to disastrous effect:
[root at bro-testmgr bro-2.2-beta]# /opt/bro/bin/broctl install
removing old policies in /var/bro/spool/installed-scripts-do-not-touch/site ... done.
removing old policies in /var/bro/spool/installed-scripts-do-not-touch/auto ... done.
creating policy directories ... done.
installing site policies ... done.
generating local-networks.bro ... done.
Traceback (most recent call last):
File "/opt/bro/bin/broctl", line 980, in <module>
File "/usr/lib64/python2.6/cmd.py", line 219, in onecmd
File "/opt/bro/bin/broctl", line 202, in do_install
result = install.install(local)
File "/opt/bro/lib/broctl/BroControl/install.py", line 112, in install
AttributeError: 'NoneType' object has no attribute 'cwd'
abnormal termination, saving state ...
This should be cleaned up to make this field user-modifiable as the others are, or at the very least we should implement a warning to users that they should not change the name of the field.
This message was sent by Atlassian JIRA
More information about the bro-dev