[Bro-Dev] [Bro-Commits] [git/bro] fastpath: Change X509 extension value parsing to not abort on malloc failures. (385438d)

Siwek, Jonathan Luke jsiwek at illinois.edu
Thu May 1 12:02:27 PDT 2014

> +	// TODO: see about using regular malloc here, there were unknown problems
> +	// using anything other than OPENSSL_malloc that need investigation.
> +	char* buffer = (char*) OPENSSL_malloc(length);

Bernhard, do you know any more details of what was wrong w/ regular malloc() here?  I think it makes sense to get away from using OpenSSL’s malloc wrapper if it’s possible.

If I change it, running the test suites on OS X don’t show a problem.  Is triggering the problem more subtle than the test suites will pick up on?

- Jon

More information about the bro-dev mailing list