[Bro-Dev] [JIRA] (BIT-1270) topic/gilbert/plugin-api-tweak

[Robin Sommer (JIRA)]

    [ https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18408#comment-18408 ] 

Robin Sommer commented on BIT-1270:
-----------------------------------

Yes, passing by value is the main part. Though still, having the separate ValWrapper seems just a tad too complex to me. Though actually a std::pair is probably better than a a tuple, as it allows access via "first" and "second", and using  std::pair<bool, X> is a pretty common pattern for flagging success/failure in addition to passing an X back. I'm not super-strong on this, but I think I'd still find that more intuitive than a separate wrapper class.

> topic/gilbert/plugin-api-tweak
> ------------------------------
>
>                 Key: BIT-1270
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1270
>             Project: Bro Issue Tracker
>          Issue Type: Improvement
>          Components: Bro
>            Reporter: gclark
>            Assignee: gclark
>
> This branch makes a few changes to the API:
> * Wraps values in a simple class (ValWrapper) that include an explicit processed / not processed flag (to avoid confusion with delayed / opaque invocations).
> * Adds a Frame argument to HookCallFunction
> * Adds support for Frame argument types to HookArgument
> * Adds support for ValWrapper argument types to HookArgument
> * Tweaks the plugin.hooks tests a bit to include new output (from additional argument)
> * Tweaks the plugin.api-version-mismatch to remove explicit home directory path via simple regex



--
This message was sent by Atlassian JIRA
(v6.4-OD-07-004#64005)